Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2276 deploy #2279

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Fix 2276 deploy #2279

merged 2 commits into from
Feb 15, 2024

Conversation

joshgamache
Copy link
Contributor

When deploying via ShipIt, #2277 failed with the following error.

I0214 21:13:56.470711 3629 request.go:668] Waited for 1.10366045s due to client-side throttling, not priority and fairness, request: GET:https://10.98.0.1:443/apis/infrastructure.cluster.x-k8s.io/v1alpha5?timeout=32s
Error: UPGRADE FAILED: YAML parse error on cas-ciip-portal/templates/jobs/terraform-apply.yaml: error converting YAML to JSON: yaml: line 48: did not find expected key

Due to similar errors exposed in the past, attempting to resolve the error by removing comments and double quote.

@joshgamache joshgamache added the Bug Something isn't working label Feb 14, 2024
@joshgamache joshgamache merged commit ebf9bb2 into develop Feb 15, 2024
16 of 17 checks passed
@joshgamache joshgamache deleted the fix-2276-deploy branch February 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLarouche JoshLarouche JoshLarouche approved these changes

@pbastia pbastia Awaiting requested review from pbastia

@mikevespi mikevespi Awaiting requested review from mikevespi

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshgamache @JoshLarouche